netdev - Re: [PATCH] net/ncsi: fix checksum validation in response packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170418000600.GA4978@gwshan>
Date:   Tue, 18 Apr 2017 10:06:00 +1000
From:   Gavin Shan <gwshan@...ux.vnet.ibm.com>
To:     David Miller <davem@...emloft.net>
Cc:     clg@...d.org, gwshan@...ux.vnet.ibm.com, joel@....id.au,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ncsi: fix checksum validation in response packet

On Mon, Apr 17, 2017 at 01:36:19PM -0400, David Miller wrote:
>From: Cédric Le Goater <clg@...d.org>
>Date: Fri, 14 Apr 2017 10:56:37 +0200
>
>> htonl was used instead of ntohl. Surely a typo.
>> 
>> Signed-off-by: Cédric Le Goater <clg@...d.org>
>
>I don't think so, "checksum" is of type "u32" thus is in host byte
>order.  Therefore "htonl()" is correct.
>

Yeah, "htonl()" is correct here. "*pchecksum" is in big-endian.
I want to know how Cédric thinks it's a problem. I guess he might
encounter the issue on the emulated NCSI channel by QEMU. On BCM5718
or BCM5719, the checksum in AEN and response packet are zero'd, meaning
the software shouldn't validate it at all.

Thanks,
Gavin