netdev - Re: [PATCH net-next v2] net: ipv6: Fix UDP early demux lookup with udp_l3mdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2f5b51a-9cf2-d35b-2f3c-1b22f3d8b31a@cumulusnetworks.com>
Date:   Tue, 18 Apr 2017 09:46:18 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        YUAN Linyu <Linyu.Yuan@...atel-sbell.com.cn>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, rshearma@...cade.com,
        eric.dumazet@...il.com, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v2] net: ipv6: Fix UDP early demux lookup with
 udp_l3mdev_accept=0

On 4/17/17 7:07 PM, Subash Abhinov Kasiviswanathan wrote:
>>> +        break;
>> I think break here should remove ?
> 
> Hi Yuan
> 
> This is similar to __udp4_lib_demux_lookup where we need to check if the
> first
> socket is an exact match or break since chains maybe long.
> 

I suggest adding the same comment as __udp4_lib_demux_lookup; it does
look odd.