netdev - Re: [PATCH net-next v2] net: ipv6: Fix UDP early demux lookup with udp_l3mdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60e43d02-035e-6536-4284-1c5b31c696ab@cumulusnetworks.com>
Date:   Tue, 18 Apr 2017 09:59:30 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        davem@...emloft.net, netdev@...r.kernel.org, rshearma@...cade.com,
        eric.dumazet@...il.com
Cc:     Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v2] net: ipv6: Fix UDP early demux lookup with
 udp_l3mdev_accept=0

On 4/17/17 5:24 PM, Subash Abhinov Kasiviswanathan wrote:
> David Ahern reported that 5425077d73e0c ("net: ipv6: Add early demux
> handler for UDP unicast") breaks udp_l3mdev_accept=0 since early
> demux for IPv6 UDP was doing a generic socket lookup which does not
> require an exact match. Fix this by making UDPv6 early demux match
> connected sockets only.
> 
> v1->v2: Take reference to socket after match as suggested by Eric
> 
> Fixes: 5425077d73e0c ("net: ipv6: Add early demux handler for UDP unicast")
> Reported-by: David Ahern <dsa@...ulusnetworks.com>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
> Cc: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv6/udp.c | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)

Besides adding the comment before the break, this looks fine to me.

Acked-by: David Ahern <dsa@...ulusnetworks.com>
Tested-by: David Ahern <dsa@...ulusnetworks.com>

If the only change for v3 is the comment before the break, please keep
the above with the new patch.