netdev - Re: [PATCH v3 net] net sched actions: allocate act cookie early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170420.163243.2282962634528556782.davem@davemloft.net>
Date:   Thu, 20 Apr 2017 16:32:43 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     w.bumiller@...xmox.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com
Subject: Re: [PATCH v3 net] net sched actions: allocate act cookie early

From: Wolfgang Bumiller <w.bumiller@...xmox.com>
Date: Thu, 20 Apr 2017 14:08:26 +0200

> Policing filters do not use the TCA_ACT_* enum and the tb[]
> nlattr array in tcf_action_init_1() doesn't get filled for
> them so we should not try to look for a TCA_ACT_COOKIE
> attribute in the then uninitialized array.
> The error handling in cookie allocation then calls
> tcf_hash_release() leading to invalid memory access later
> on.
> Additionally, if cookie allocation fails after an already
> existing non-policing filter has successfully been changed,
> tcf_action_release() should not be called, also we would
> have to roll back the changes in the error handling, so
> instead we now allocate the cookie early and assign it on
> success at the end.
> 
> CVE-2017-7979
> Fixes: 1045ba77a596 ("net sched actions: Add support for user cookies")
> Signed-off-by: Wolfgang Bumiller <w.bumiller@...xmox.com>
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

Applied and queued up for -stable.