netdev - Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6f4f382-26ac-6679-adba-605e8f29cf6a@cumulusnetworks.com>
Date:   Thu, 20 Apr 2017 16:43:03 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>,
        Andrey Konovalov <andreyknvl@...gle.com>
Subject: Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from
 userspace

On 4/20/17 4:39 PM, Cong Wang wrote:
> On Wed, Apr 19, 2017 at 2:19 PM, David Ahern <dsa@...ulusnetworks.com> wrote:
>>
>> Fix by checking for the flag and failing with EINVAL.
>>
> 
> I am still not sure about this. There are a few unused bits in
> this flag, we simply ignore the rest, right? Why should we
> reject this one instead of all of those we don't use?
> 

RTF_PCPU most definitely should not be set by userspace. arguably it
should not be returned to userspace either, but it is part of the uapi.


I scanned the others. It is not clear that others should fail with
EINVAL. Certainly a mask of unused flags can be added, but to me that is
on top of this bug fix.