netdev - Re: macvlan: Fix device ref leak when purging bc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170425.104254.1884694182452846750.davem@davemloft.net>
Date:   Tue, 25 Apr 2017 10:42:54 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     herbert@...dor.apana.org.au
Cc:     Joe.Ghalam@...l.com, Clifford.Wichmann@...l.com,
        netdev@...r.kernel.org
Subject: Re: macvlan: Fix device ref leak when purging bc_queue

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 20 Apr 2017 20:55:12 +0800

> When a parent macvlan device is destroyed we end up purging its
> broadcast queue without dropping the device reference count on
> the packet source device.  This causes the source device to linger.
> 
> This patch drops that reference count.
> 
> Fixes: 260916dfb48c ("macvlan: Fix potential use-after free for...")
> Reported-by: Joe Ghalam <Joe.Ghalam@...l.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied and queued up for -stable, thanks Herbert.