netdev - Re: [PATCH net-next] ipvlan: use pernet operations and restrict l3s hooks to master netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170425.104349.2185336124073374885.davem@davemloft.net>
Date:   Tue, 25 Apr 2017 10:43:49 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, maheshb@...gle.com
Subject: Re: [PATCH net-next] ipvlan: use pernet operations and restrict
 l3s hooks to master netns

From: Florian Westphal <fw@...len.de>
Date: Thu, 20 Apr 2017 18:08:15 +0200

> commit 4fbae7d83c98c30efc ("ipvlan: Introduce l3s mode") added
> registration of netfilter hooks via nf_register_hooks().
> 
> This API provides the illusion of 'global' netfilter hooks by placing the
> hooks in all current and future network namespaces.
> 
> In case of ipvlan the hook appears to be only needed in the namespace
> that contains the ipvlan master device (i.e., usually init_net), so
> placing them in all namespaces is not needed.
> 
> This switches ipvlan driver to pernet operations, and then only registers
> hooks in namespaces where a ipvlan master device is set to l3s mode.
> 
> Extra care has to be taken when the master device is moved to another
> namespace, as we might have to 'move' the netfilter hooks too.
> 
> This is done by storing the namespace the ipvlan port was created in.
> On REGISTER event, do (un)register operations in the old/new namespaces.
> 
> This will also allow removal of the nf_register_hooks() in a future patch.
> 
> Cc: Mahesh Bandewar <maheshb@...gle.com>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks Florian.