netdev - Re: Fw: New Defects reported by Coverity Scan for Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUTxNdp-uC0pGkvW0uceOpouAQ1abrU-u4wvR9ftqXN7w@mail.gmail.com>
Date:   Mon, 24 Apr 2017 17:09:38 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Jamal Hadi Salim <hadi@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: Fw: New Defects reported by Coverity Scan for Linux

On Mon, Apr 24, 2017 at 4:41 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> This looks like a false positive
> ________________________________________________________________________________________________________
> *** CID 1405487:  Resource leaks  (RESOURCE_LEAK)
> /net/sched/act_api.c: 635 in tcf_action_init_1()
> 629              * if it exists and is only bound to in a_o->init() then
> 630              * ACT_P_CREATED is not returned (a zero is).
> 631              */
> 632             if (err != ACT_P_CREATED)
> 633                     module_put(a_o->owner);
> 634
>>>>     CID 1405487:  Resource leaks  (RESOURCE_LEAK)
>>>>     Variable "cookie" going out of scope leaks the storage it points to.
> 635             return a;

I don't see how we could leak it either.