netdev - Re: Fw: New Defects reported by Coverity Scan for Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2017 20:23:06 -0400
From:   Jamal Hadi Salim <hadi@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Jiri Pirko <jiri@...nulli.us>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: Fw: New Defects reported by Coverity Scan for Linux

Yeah, not sure i see it either.

cheers,
jamal

On Mon, Apr 24, 2017 at 8:09 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Mon, Apr 24, 2017 at 4:41 PM, Stephen Hemminger
> <stephen@...workplumber.org> wrote:
>> This looks like a false positive
>> ________________________________________________________________________________________________________
>> *** CID 1405487:  Resource leaks  (RESOURCE_LEAK)
>> /net/sched/act_api.c: 635 in tcf_action_init_1()
>> 629              * if it exists and is only bound to in a_o->init() then
>> 630              * ACT_P_CREATED is not returned (a zero is).
>> 631              */
>> 632             if (err != ACT_P_CREATED)
>> 633                     module_put(a_o->owner);
>> 634
>>>>>     CID 1405487:  Resource leaks  (RESOURCE_LEAK)
>>>>>     Variable "cookie" going out of scope leaks the storage it points to.
>> 635             return a;
>
> I don't see how we could leak it either.