[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFE070F@AcuExch.aculab.com>
Date: Thu, 27 Apr 2017 15:27:13 +0000
From: David Laight <David.Laight@...LAB.COM>
To: "'Duyck, Alexander H'" <alexander.h.duyck@...el.com>,
"Chiappero, Marco" <marco.chiappero@...el.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "David S . Miller" <davem@...emloft.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
"Grandhi, Sainath" <sainath.grandhi@...el.com>,
Mahesh Bandewar <maheshb@...gle.com>
Subject: RE: [PATCH net-next 8/9] ipvlan: improve compiler hints
From: Duyck, Alexander H
> Sent: 27 April 2017 16:21
...
> > -unsigned int ipvlan_mac_hash(const unsigned char *addr)
> > +inline unsigned int ipvlan_mac_hash(const unsigned char *addr)
> > {
> > u32 hash = jhash_1word(__get_unaligned_cpu32(addr + 2),
> > ipvlan_jhash_secret);
>
> I'm kind of surprised this isn't causing a problem with differing declarations between the declaration
> here and the declaration in ipvlan.h. Normally for inlining something like this you would change it to
> a "static inline" and move the entire declaration into the header file.
You get a callable copy for external callers and local calls inlined.
Not usually what you want.
David
Powered by blists - more mailing lists