netdev - Re: [PATCH net-next 8/9] ipvlan: improve compiler hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170427.120526.172017262253091302.davem@davemloft.net>
Date:   Thu, 27 Apr 2017 12:05:26 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     alexander.h.duyck@...el.com
Cc:     marco.chiappero@...el.com, netdev@...r.kernel.org,
        jeffrey.t.kirsher@...el.com, sainath.grandhi@...el.com,
        maheshb@...gle.com
Subject: Re: [PATCH net-next 8/9] ipvlan: improve compiler hints

From: "Duyck, Alexander H" <alexander.h.duyck@...el.com>
Date: Thu, 27 Apr 2017 15:21:16 +0000

>> -----Original Message-----
>> From: Chiappero, Marco
>> Sent: Thursday, April 27, 2017 7:52 AM
>> To: netdev@...r.kernel.org
>> Cc: David S . Miller <davem@...emloft.net>; Kirsher, Jeffrey T
>> <jeffrey.t.kirsher@...el.com>; Duyck, Alexander H
>> <alexander.h.duyck@...el.com>; Grandhi, Sainath
>> <sainath.grandhi@...el.com>; Mahesh Bandewar <maheshb@...gle.com>;
>> Chiappero, Marco <marco.chiappero@...el.com>
>> Subject: [PATCH net-next 8/9] ipvlan: improve compiler hints
>> 
>> Extend inlining and branch prediction hints.
>> 
>> Signed-off-by: Marco Chiappero <marco.chiappero@...el.com>
>> ---
>>  drivers/net/ipvlan/ipvlan_core.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/net/ipvlan/ipvlan_core.c b/drivers/net/ipvlan/ipvlan_core.c
>> index a9fc1b5..67e342d 100644
>> --- a/drivers/net/ipvlan/ipvlan_core.c
>> +++ b/drivers/net/ipvlan/ipvlan_core.c
>> @@ -88,7 +88,7 @@ void ipvlan_ht_addr_del(struct ipvl_addr *addr)
>>  	hlist_del_init_rcu(&addr->hlnode);
>>  }
>> 
>> -unsigned int ipvlan_mac_hash(const unsigned char *addr)
>> +inline unsigned int ipvlan_mac_hash(const unsigned char *addr)
>>  {
>>  	u32 hash = jhash_1word(__get_unaligned_cpu32(addr + 2),
>>  			       ipvlan_jhash_secret);
> 
> I'm kind of surprised this isn't causing a problem with differing
> declarations between the declaration here and the declaration in
> ipvlan.h. Normally for inlining something like this you would change
> it to a "static inline" and move the entire declaration into the
> header file.

No inlines in foo.c files please, seriously let the compiler decide
it knows better than you.