lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Apr 2017 07:03:07 -0600 From: David Ahern <dsa@...ulusnetworks.com> To: Dan Carpenter <dan.carpenter@...cle.com>, "David S. Miller" <davem@...emloft.net>, Pan Bian <bianpan2016@....com> Cc: Roopa Prabhu <roopa@...ulusnetworks.com>, Robert Shearman <rshearma@...cade.com>, Tom Herbert <tom@...bertland.com>, David Lebrun <david.lebrun@...ouvain.be>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH net-next] lwtunnel: fix error path in lwtunnel_fill_encap() On 4/28/17 7:03 AM, Dan Carpenter wrote: > We recently added a check to see if nla_nest_start() fails. There are > two issues with that. First, if it fails then I don't think we should > call nla_nest_cancel(). Second, it's slightly convoluted but the > current code returns success but we should return -EMSGSIZE instead. > > Fixes: a50fe0ffd76f ("lwtunnel: check return value of nla_nest_start") > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> > Acked-by: David Ahern <dsa@...ulusnetworks.com>
Powered by blists - more mailing lists