lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170502120754.GD1877@nanopsycho.orion> Date: Tue, 2 May 2017 14:07:54 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Jamal Hadi Salim <jhs@...atatu.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, xiyou.wangcong@...il.com, mlxsw@...lanox.com Subject: Re: [patch net-next repost] net: sched: add helpers to handle extended actions Tue, May 02, 2017 at 01:59:20PM CEST, jhs@...atatu.com wrote: >On 17-05-02 04:12 AM, Jiri Pirko wrote: >> From: Jiri Pirko <jiri@...lanox.com> >> >> Jump is now the only one using value action opcode. This is going to >> change soon. So introduce helpers to work with this. Convert TC_ACT_JUMP. >> >> This also fixes the TC_ACT_JUMP check, which is incorrectly done as a >> bit check, not a value check. >> >> Fixes: e0ee84ded796 ("net sched actions: Complete the JUMPX opcode") >> Signed-off-by: Jiri Pirko <jiri@...lanox.com> >> --- >> Dave, I'm sending this for -net-next although I know it is closed. But >> the mentioned commit is not yet in -net. Feel free to take this either >> to -net-next or -net, whatever suits you better. Thanks. > >I think you are pushing the boundary a little calling it a bug fix Well, it is a bugfix. Otherwise we could not use bit 1 for anything else then jump in the future. This is also UAPI. That's why I'm pushing it as a fix. >and this could go with your patch series instead. >The name TC_ACT_EXT_CMP should be TC_ACT_EXT_CMP_OPCODE I was thinking about it as well, I would like to keep it shorter. The current name is quite appropriate and it is clear what the macro does. >Other than that: > >Acked-by: Jamal Hadi Salim <jhs@...atatu.com> Thanks.
Powered by blists - more mailing lists