netdev - Re: [PATCH] net/sched: remove redundant null check on head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170503151212.GD2077@nanopsycho.orion>
Date:   Wed, 3 May 2017 17:12:12 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     walter harms <wharms@....de>
Cc:     Colin King <colin.king@...onical.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net/sched: remove redundant null check on head

Wed, May 03, 2017 at 04:21:15PM CEST, wharms@....de wrote:
>
>
>Am 03.05.2017 15:50, schrieb Colin King:
>> From: Colin Ian King <colin.king@...onical.com>
>> 
>> head is previously null checked and so the 2nd null check on head
>> is redundant and therefore can be removed.
>> 
>> Detected by CoverityScan, CID#1399505 ("Logically dead code")
>> 
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  net/sched/cls_matchall.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c
>> index 2efb36c08f2a..dee469fed967 100644
>> --- a/net/sched/cls_matchall.c
>> +++ b/net/sched/cls_matchall.c
>> @@ -203,8 +203,7 @@ static int mall_change(struct net *net, struct sk_buff *in_skb,
>>  
>>  	*arg = (unsigned long) head;
>>  	rcu_assign_pointer(tp->root, new);
>> -	if (head)
>> -		call_rcu(&head->rcu, mall_destroy_rcu);
>> +	call_rcu(&head->rcu, mall_destroy_rcu);
>>  	return 0;
>>  
>>  err_replace_hw_filter:
>
>
>if someone cares .. the err=0 in the the line above the patch is also useless
>because err is never used again. Merging both if will save 1 indent level.
>
> err = mall_replace_hw_filter(tp, new, (unsigned long) new);
> if (err && tc_skip_sw(flags) )
>	goto errout;


true, however unrelated to this patch :)

Please submit as a separate patch.

Thanks.