netdev - Re: [PATCH 1/1] forcedeth: remove unnecessary carrier status check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170504.105807.2275033957289769591.davem@davemloft.net>
Date:   Thu, 04 May 2017 10:58:07 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     yanjun.zhu@...cle.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] forcedeth: remove unnecessary carrier status check

From: Zhu Yanjun <yanjun.zhu@...cle.com>
Date: Wed,  3 May 2017 00:43:42 -0400

> Since netif_carrier_on() will do nothing if device's
> carrier is already on, so it's unnecessary to do
> carrier status check.
> 
> It's the same for netif_carrier_off().
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>

Applied, thanks.