netdev - Re: [PATCH v2 net] tcp: do not inherit fastopen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170504.110057.23190424531991586.davem@davemloft.net>
Date:   Thu, 04 May 2017 11:00:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, weiwan@...gle.com, andreyknvl@...gle.com
Subject: Re: [PATCH v2 net] tcp: do not inherit fastopen_req from parent

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 03 May 2017 06:39:31 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Under fuzzer stress, it is possible that a child gets a non NULL
> fastopen_req pointer from its parent at accept() time, when/if parent
> morphs from listener to active session.
> 
> We need to make sure this can not happen, by clearing the field after
> socket cloning.
 ...
> Fixes: e994b2f0fb92 ("tcp: do not lock listener to process SYN packets")
> Fixes: 7db92362d2fe ("tcp: fix potential double free issue for fastopen_req")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>

Applied and queued up for -stable, thanks Eric.