lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <9932ee63-f766-49ce-d760-9a0bd06f0657@users.sourceforge.net> Date: Mon, 8 May 2017 19:29:12 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Philippe Reynes <tremyfr@...il.com>, Stefan Wahren <stefan.wahren@...e.com> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Mon, 8 May 2017 19:21:27 +0200 A bit of data was put into a sequence by separate function calls. Print the same data together with adjusted seq_printf() calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- drivers/net/ethernet/qualcomm/qca_debug.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index d145df98feff..27b5c1dd27d0 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -81,11 +81,7 @@ qcaspi_info_show(struct seq_file *s, void *what) else seq_puts(s, "in use"); - seq_puts(s, "\n"); - - seq_printf(s, "TX ring size : %u\n", - qca->txr.size); - + seq_printf(s, "\nTX ring size : %u\n", qca->txr.size); seq_printf(s, "Sync state : %u (", (unsigned int)qca->sync); switch (qca->sync) { @@ -102,10 +98,8 @@ qcaspi_info_show(struct seq_file *s, void *what) seq_puts(s, "INVALID"); break; } - seq_puts(s, ")\n"); - seq_printf(s, "IRQ : %d\n", - qca->spi_dev->irq); + seq_printf(s, ")\nIRQ : %d\n", qca->spi_dev->irq); seq_printf(s, "INTR REQ : %u\n", qca->intr_req); seq_printf(s, "INTR SVC : %u\n", -- 2.12.2
Powered by blists - more mailing lists