lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <290d2473-73bd-70db-b6ef-c50331812f31@i2se.com> Date: Tue, 9 May 2017 09:07:52 +0200 From: Stefan Wahren <stefan.wahren@...e.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net>, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Philippe Reynes <tremyfr@...il.com> Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show() Am 08.05.2017 um 19:29 schrieb SF Markus Elfring: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Mon, 8 May 2017 19:21:27 +0200 > > A bit of data was put into a sequence by separate function calls. > Print the same data together with adjusted seq_printf() calls instead. Sorry, i'm not happy with this patch. It doesn't increase readabilityand mixes the output of multiple lines. The only benefit is a little bit higher performance. But for debugfs this won't be necessary. Stefan > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> > --- > drivers/net/ethernet/qualcomm/qca_debug.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) >
Powered by blists - more mailing lists