netdev - Re: [PATCH] wil6210: Replace five seq_puts() calls by seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 09 May 2017 05:25:23 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     wil6210@....qualcomm.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, Kalle Valo <kvalo@...eaurora.org>,
        Maya Erez <qca_merez@....qualcomm.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] wil6210: Replace five seq_puts() calls by seq_putc()

On Tue, 2017-05-09 at 09:50 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 8 May 2017 22:22:04 +0200
> 
> Five single characters (line breaks) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
> 
> This issue was detected by using the Coccinelle software.

There is no _issue_ at all here, only a matter of taste.

printf("\n")  or putchar('\n')  in some slow path is really not that
interesting.