netdev - Re: [PATCH iproute2 v2 1/1] vxlan: Add support for modifying vxlan device attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29877f9d-f6c7-5823-4ecb-4c2d1ee2b525@oracle.com>
Date:   Wed, 10 May 2017 00:31:27 -0700
From:   Girish Moodalbail <girish.moodalbail@...cle.com>
To:     Roman Mashak <mrv@...atatu.com>
Cc:     stephen@...workplumber.org, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v2 1/1] vxlan: Add support for modifying vxlan
 device attributes

On 5/7/17 7:40 AM, Roman Mashak wrote:
> Girish Moodalbail <girish.moodalbail@...cle.com> writes:
>
>
> [...]
>
>>  ip/iplink_vxlan.c | 251 +++++++++++++++++++++++++++++++-----------------------
>>  1 file changed, 143 insertions(+), 108 deletions(-)
>>
>> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
>> index b4ebb13..2bd619d 100644
>> --- a/ip/iplink_vxlan.c
>> +++ b/ip/iplink_vxlan.c
>> @@ -21,6 +21,8 @@
>>  #include "utils.h"
>>  #include "ip_common.h"
>>
>> +#define VXLAN_ATTRSET(attrs, type) (((attrs) & (1L << (type))) != 0)
>
> I think you can drop '!= 0' part in the macro.

Sure it can be done that way as well. However, I have seen both forms in use in 
iproute2 code base, so I would like to keep this as is unless you feel strongly 
about it. Furthermore, running 'checkpatch.pl --strict' on the patch didn't 
complain too.

regards,
~Girish

>
> [...]
>
>>
>> +static void check_duparg(__u64 *attrs, int type, const char *key,
>> +			 const char *argv)
>> +{
>> +	if (!VXLAN_ATTRSET(*attrs, type)) {
>> +		*attrs |= (1L << type);
>> +		return;
>> +	}
>> +	duparg2(key, argv);
>> +}
>
> [...]
>