lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170511111222.5edc4b0c@xeon-e3> Date: Thu, 11 May 2017 11:12:22 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Girish Moodalbail <girish.moodalbail@...cle.com> Cc: <netdev@...r.kernel.org> Subject: Re: [PATCH iproute2 v2 1/1] vxlan: Add support for modifying vxlan device attributes On Sat, 6 May 2017 11:37:43 -0700 Girish Moodalbail <girish.moodalbail@...cle.com> wrote: > Ability to change vxlan device attributes was added to kernel through > commit 8bcdc4f3a20b ("vxlan: add changelink support"), however one > cannot do the same through ip(8) command. Changing the allowed vxlan > device attributes using 'ip link set dev <vxlan_name> type vxlan > <allowed_attributes>' currently fails with 'operation not supported' > error. This failure is due to the incorrect rtnetlink message > construction for the 'ip link set' operation. > > The vxlan_parse_opt() callback function is called for parsing options > for both 'ip link add' and 'ip link set'. For the 'add' case, we pass > down default values for those attributes that were not provided as CLI > options. However, for the 'set' case we should be only passing down the > explicitly provided attributes and not any other (default) attributes. > > Signed-off-by: Girish Moodalbail <girish.moodalbail@...cle.com> I like this much better. Applied, Thanks.
Powered by blists - more mailing lists