netdev - Re: [PATCH] mdio: mux: fix device_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170515.142924.50104848465845824.davem@davemloft.net>
Date:   Mon, 15 May 2017 14:29:24 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     jon.mason@...adcom.com
Cc:     f.fainelli@...il.com, julia.lawall@...6.fr, netdev@...r.kernel.org,
        andrew@...n.ch, kbuild-all@...org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

From: Jon Mason <jon.mason@...adcom.com>
Date: Mon, 15 May 2017 13:37:09 -0400

> I would prefer #1, as I would not want to break something that was
> currently working.  However, I think we should add much error logging
> here to let people know their DT is hosed (instead of silently
> working).  So, this would mean applying Julia's patch, and I'll do a
> follow-on to change the breaks to continues and add the error logging
> (assuming others agree with me).

Ok, I've applied Julia's patch.

I agree that we shouldn't fail the whole list just because one does.
And yes, we should emit enough diagnostics so that people can figure
out what the problem is.