netdev - Re: [PATCH net] ipv6: avoid dad-failures for addresses with NODAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170515.143239.984412925216923610.davem@davemloft.net>
Date:   Mon, 15 May 2017 14:32:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mahesh@...dewar.net
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
        kaber@...sh.net, netdev@...r.kernel.org, edumazet@...gle.com,
        maheshb@...gle.com
Subject: Re: [PATCH net] ipv6: avoid dad-failures for addresses with NODAD

From: David Miller <davem@...emloft.net>
Date: Mon, 15 May 2017 14:26:55 -0400 (EDT)

> From: Mahesh Bandewar <mahesh@...dewar.net>
> Date: Fri, 12 May 2017 17:03:39 -0700
> 
>> From: Mahesh Bandewar <maheshb@...gle.com>
>> 
>> Every address gets added with TENTATIVE flag even for the addresses with
>> IFA_F_NODAD flag and dad-work is scheduled for them. During this DAD process
>> we realize it's an address with NODAD and complete the process without
>> sending any probe. However the TENTATIVE flags stays on the
>> address for sometime enough to cause misinterpretation when we receive a NS.
>> While processing NS, if the address has TENTATIVE flag, we mark it DADFAILED
>> and endup with an address that was originally configured as NODAD with
>> DADFAILED.
>> 
>> We can't avoid scheduling dad_work for addresses with NODAD but we can
>> avoid adding TENTATIVE flag to avoid this racy situation.
>> 
>> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> 
> This doesn't apply cleanly to the net tree, please respin.

Ignore this, I was trying to apply the wrong patch.

Applied, thank you.