netdev - Re: [PATCH] net: Improve handling of failures on link and route dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170516.145436.967557028017706784.davem@davemloft.net>
Date:   Tue, 16 May 2017 14:54:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, mq@....cz
Subject: Re: [PATCH] net: Improve handling of failures on link and route
 dumps

From: David Ahern <dsahern@...il.com>
Date: Mon, 15 May 2017 23:19:17 -0700

> In general, rtnetlink dumps do not anticipate failure to dump a single
> object (e.g., link or route) on a single pass. As both route and link
> objects have grown via more attributes, that is no longer a given.
> 
> netlink dumps can handle a failure if the dump function returns an
> error; specifically, netlink_dump adds the return code to the response
> if it is <= 0 so userspace is notified of the failure. The missing
> piece is the rtnetlink dump functions returning the error.
> 
> Fix route and link dump functions to return the errors if no object is
> added to an skb (detected by skb->len != 0). IPv6 route dumps
> (rt6_dump_route) already return the error; this patch updates IPv4 and
> link dumps. Other dump functions may need to be ajusted as well.
> 
> Reported-by: Jan Moskyto Matejka <mq@....cz>
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
> The recent IPv6 multipath change brought this to light because of the
> ease at which ipv6 route appends can exceed a buffer size, but it seems
> to be a day 1 problem.

Applied and queued up for -stable, thanks David.