lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170516080049.4fvo4hkj4e6v7r3v@piout.net> Date: Tue, 16 May 2017 10:00:49 +0200 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Oliver Hartkopp <socketcan@...tkopp.net> Cc: Marc Kleine-Budde <mkl@...gutronix.de>, Quentin Schulz <quentin.schulz@...e-electrons.com>, wg@...ndegger.com, mario.huettel@....net, linux-can@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, thomas.petazzoni@...e-electrons.com Subject: Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function Hi, On 15/05/2017 at 20:51:30 -0700, Oliver Hartkopp wrote: > On 05/15/2017 06:50 AM, Marc Kleine-Budde wrote: > > On 05/12/2017 08:37 AM, Quentin Schulz wrote: > > > On 05/05/2017 15:50, Quentin Schulz wrote: > > > > To avoid possible ECC/parity checksum errors when reading an > > > > uninitialized buffer, the entire Message RAM is initialized when probing > > > > the driver. This initialization is done in the same function reading the > > > > Device Tree properties. > > > > > > > > This patch moves the RAM initialization to a separate function so it can > > > > be called separately from device initialization from Device Tree. > > > > > > > > Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com> > > > > > > It's been a week since I sent this patch series. Any comments? > > > > Looks good, added to linux-can-next. > > Isn't this a fix for linux-can instead? > > At least it would make no sense to me to have the upgraded M_CAN driver in > Linux 4.12 without this fix. > The related suspend mode on the sama5d2 is not present in v4.12 so I think this can wait v4.13. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Powered by blists - more mailing lists