netdev - Re: [patch net-next v2 10/10] net: sched: add termination action to allow goto chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6118ec19-9093-eaf2-6677-28c128e636a9@mojatatu.com>
Date:   Tue, 16 May 2017 08:46:26 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        xiyou.wangcong@...il.com, dsa@...ulusnetworks.com,
        edumazet@...gle.com, stephen@...workplumber.org,
        alexander.h.duyck@...el.com, simon.horman@...ronome.com,
        mlxsw@...lanox.com, alexei.starovoitov@...il.com
Subject: Re: [patch net-next v2 10/10] net: sched: add termination action to
 allow goto chain

On 17-05-16 03:59 AM, Daniel Borkmann wrote:
> On 05/16/2017 06:43 AM, Jiri Pirko wrote:
>> Mon, May 15, 2017 at 10:02:08PM CEST, daniel@...earbox.net wrote:

[..]
>>>
>>> Given this goto chain feature is pretty much only interesting for hw
>>> offloads, can we move this further away from the sw fast path to not
>>> add up to the cost per packet? (I doubt anyone is using
>>> TC_ACT_RECLASSIFY
>>> in sw as well ...)
>>
>> I don't think so. First of all, the whole thing would be broken then in
>> sw. It is useful to have it in sw, at least for testing reasons.
>> So I would leave the unlikely and add it to the second check as well.
>
> Ok, lets go with that then, thanks!

Side comment:
I dont think this is only useful for h/w offloads;->

cheers,
jamal