netdev - RE: [PATCH net-next] qed: Utilize FW 8.20.0.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BLUPR0701MB20044DA1ADB765CB620121778DE40@BLUPR0701MB2004.namprd07.prod.outlook.com>
Date:   Thu, 18 May 2017 15:28:21 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "Dupuis, Chad" <Chad.Dupuis@...ium.com>,
        "Amrani, Ram" <Ram.Amrani@...ium.com>,
        "Tayar, Tomer" <Tomer.Tayar@...ium.com>,
        "Rangankar, Manish" <Manish.Rangankar@...ium.com>
Subject: RE: [PATCH net-next] qed: Utilize FW 8.20.0.0

> >> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0
> >> firmware. The changes are mostly contained in qed with minor changes
> >> to qedi due to some HSI changes.
> >>
> >> Content-wise, the firmware contains fixes to various issues exposed
> >> since the release of the previous firmware, including:
> >>  - Corrects iSCSI fast retransmit when data digest is enabled.
> >>  - Stop draining packets when receiving several consecutive PFCs.
> >>  - Prevent possible assertion when consecutively opening/closing
> >>    many connections.
> >>  - Prevent possible assertion due to too long BDQ fetch time.
> >>
> >> In addition, the new firmware would allow us to later add iWARP
> >> support in qed and qedr.
> >>
> >> Signed-off-by: Chad Dupuis <Chad.Dupuis@...ium.com>
> >> Signed-off-by: Ram Amrani <Ram.Amrani@...ium.com>
> >> Signed-off-by: Tomer Tayar <Tomer.Tayar@...ium.com>
> >> Signed-off-by: Manish Rangankar <Manish.Rangankar@...ium.com>
> >> Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>
> >
> > Applied.
> 
> Actually I had to revert.  Please look at the compiler output before
> submitting changes:
> 
> drivers/net/ethernet/qlogic/qed/qed_debug.c: In function ‘qed_grc_dump’:
> drivers/net/ethernet/qlogic/qed/qed_debug.c:2425:6: warning: ‘addr’ may
> be used uninitialized in this function [-Wmaybe-uninitialized]
>   u32 byte_addr = DWORDS_TO_BYTES(addr), offset = 0, i;
>       ^
> drivers/net/ethernet/qlogic/qed/qed_debug.c:3534:7: note: ‘addr’ was
> declared here
>    u32 addr, size = RSS_REG_RSS_RAM_DATA_SIZE;
>        ^
> 
> 'addr' is never, ever, assigned a value, yet it is passed into a function as an
> argument.

Sorry about that. Will send v2 [hopefully] later today.