netdev - Re: [PATCH net-next] qed: Utilize FW 8.20.0.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170518.104300.795177460216894201.davem@davemloft.net>
Date:   Thu, 18 May 2017 10:43:00 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...ium.com
Cc:     netdev@...r.kernel.org, linux-scsi@...r.kernel.org,
        Chad.Dupuis@...ium.com, Ram.Amrani@...ium.com,
        Tomer.Tayar@...ium.com, Manish.Rangankar@...ium.com
Subject: Re: [PATCH net-next] qed: Utilize FW 8.20.0.0

From: David Miller <davem@...emloft.net>
Date: Thu, 18 May 2017 10:34:28 -0400 (EDT)

> From: Yuval Mintz <Yuval.Mintz@...ium.com>
> Date: Wed, 17 May 2017 22:38:40 +0300
> 
>> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0
>> firmware. The changes are mostly contained in qed with minor changes
>> to qedi due to some HSI changes.
>> 
>> Content-wise, the firmware contains fixes to various issues exposed
>> since the release of the previous firmware, including:
>>  - Corrects iSCSI fast retransmit when data digest is enabled.
>>  - Stop draining packets when receiving several consecutive PFCs.
>>  - Prevent possible assertion when consecutively opening/closing
>>    many connections.
>>  - Prevent possible assertion due to too long BDQ fetch time.
>> 
>> In addition, the new firmware would allow us to later add iWARP support
>> in qed and qedr.
>> 
>> Signed-off-by: Chad Dupuis <Chad.Dupuis@...ium.com>
>> Signed-off-by: Ram Amrani <Ram.Amrani@...ium.com>
>> Signed-off-by: Tomer Tayar <Tomer.Tayar@...ium.com>
>> Signed-off-by: Manish Rangankar <Manish.Rangankar@...ium.com>
>> Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>
> 
> Applied.

Actually I had to revert.  Please look at the compiler output before
submitting changes:

drivers/net/ethernet/qlogic/qed/qed_debug.c: In function ‘qed_grc_dump’:
drivers/net/ethernet/qlogic/qed/qed_debug.c:2425:6: warning: ‘addr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  u32 byte_addr = DWORDS_TO_BYTES(addr), offset = 0, i;
      ^
drivers/net/ethernet/qlogic/qed/qed_debug.c:3534:7: note: ‘addr’ was declared here
   u32 addr, size = RSS_REG_RSS_RAM_DATA_SIZE;
       ^

'addr' is never, ever, assigned a value, yet it is passed into a function as an
argument.