netdev - Re: [PATCH v2] e1000e: Don't return uninitialized stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170518.104614.1739169308591707817.davem@davemloft.net>
Date:   Thu, 18 May 2017 10:46:14 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bpoirier@...e.com
Cc:     jeffrey.t.kirsher@...el.com, s.priebe@...fihost.ag,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        pmenzel@...gen.mpg.de, sasha.neftin@...el.com,
        aaron.f.brown@...el.com, stephen@...workplumber.org
Subject: Re: [PATCH v2] e1000e: Don't return uninitialized stats

From: Benjamin Poirier <bpoirier@...e.com>
Date: Wed, 17 May 2017 16:24:13 -0400

> Some statistics passed to ethtool are garbage because e1000e_get_stats64()
> doesn't write them, for example: tx_heartbeat_errors. This leaks kernel
> memory to userspace and confuses users.
> 
> Do like ixgbe and use dev_get_stats() which first zeroes out
> rtnl_link_stats64.
> 
> Fixes: 5944701df90d ("net: remove useless memset's in drivers get_stats64")
> Reported-by: Stefan Priebe <s.priebe@...fihost.ag>
> Signed-off-by: Benjamin Poirier <bpoirier@...e.com>

Jeff, please be sure to pick this up, thanks.