netdev - Re: [PATCH v2] e1000e: Don't return uninitialized stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 May 2017 01:16:51 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     David Miller <davem@...emloft.net>, bpoirier@...e.com
Cc:     s.priebe@...fihost.ag, intel-wired-lan@...ts.osuosl.org,
        netdev@...r.kernel.org, pmenzel@...gen.mpg.de,
        sasha.neftin@...el.com, aaron.f.brown@...el.com,
        stephen@...workplumber.org
Subject: Re: [PATCH v2] e1000e: Don't return uninitialized stats

On Thu, 2017-05-18 at 10:46 -0400, David Miller wrote:
> From: Benjamin Poirier <bpoirier@...e.com>
> Date: Wed, 17 May 2017 16:24:13 -0400
> 
> > Some statistics passed to ethtool are garbage because
> > e1000e_get_stats64()
> > doesn't write them, for example: tx_heartbeat_errors. This leaks kernel
> > memory to userspace and confuses users.
> > 
> > Do like ixgbe and use dev_get_stats() which first zeroes out
> > rtnl_link_stats64.
> > 
> > Fixes: 5944701df90d ("net: remove useless memset's in drivers
> > get_stats64")
> > Reported-by: Stefan Priebe <s.priebe@...fihost.ag>
> > Signed-off-by: Benjamin Poirier <bpoirier@...e.com>
> 
> Jeff, please be sure to pick this up, thanks.

Yep, I have it in my tree, thanks.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)