netdev - Re: [Patch net] vsock: use new wait API for vsock_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170522.143951.945710292413025877.davem@davemloft.net>
Date:   Mon, 22 May 2017 14:39:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, stefanha@...hat.com, jhansen@...are.com,
        mst@...hat.com, imbrenda@...ux.vnet.ibm.com
Subject: Re: [Patch net] vsock: use new wait API for vsock_stream_sendmsg()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 19 May 2017 11:21:59 -0700

> As reported by Michal, vsock_stream_sendmsg() could still
> sleep at vsock_stream_has_space() after prepare_to_wait():
> 
>   vsock_stream_has_space
>     vmci_transport_stream_has_space
>       vmci_qpair_produce_free_space
>         qp_lock
>           qp_acquire_queue_mutex
>             mutex_lock
> 
> Just switch to the new wait API like we did for commit
> d9dc8b0f8b4e ("net: fix sleeping for sk_wait_event()").
> 
> Reported-by: Michal Kubecek <mkubecek@...e.cz>
> Cc: Stefan Hajnoczi <stefanha@...hat.com>
> Cc: Jorgen Hansen <jhansen@...are.com>
> Cc: "Michael S. Tsirkin" <mst@...hat.com>
> Cc: Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thank you.