netdev - Re: [Patch net] vsock: use new wait API for vsock_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170522135605.GC24772@stefanha-x1.localdomain>
Date:   Mon, 22 May 2017 14:56:05 +0100
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, Jorgen Hansen <jhansen@...are.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>
Subject: Re: [Patch net] vsock: use new wait API for vsock_stream_sendmsg()

On Fri, May 19, 2017 at 11:21:59AM -0700, Cong Wang wrote:
> As reported by Michal, vsock_stream_sendmsg() could still
> sleep at vsock_stream_has_space() after prepare_to_wait():
> 
>   vsock_stream_has_space
>     vmci_transport_stream_has_space
>       vmci_qpair_produce_free_space
>         qp_lock
>           qp_acquire_queue_mutex
>             mutex_lock
> 
> Just switch to the new wait API like we did for commit
> d9dc8b0f8b4e ("net: fix sleeping for sk_wait_event()").
> 
> Reported-by: Michal Kubecek <mkubecek@...e.cz>
> Cc: Stefan Hajnoczi <stefanha@...hat.com>
> Cc: Jorgen Hansen <jhansen@...are.com>
> Cc: "Michael S. Tsirkin" <mst@...hat.com>
> Cc: Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  net/vmw_vsock/af_vsock.c | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)