netdev - Re: [PATCH net-next] net: rps: Add the rfs_needed check when record flow hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170525.131141.1106125565617394205.davem@davemloft.net>
Date:   Thu, 25 May 2017 13:11:41 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     gfree.wind@....163.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: rps: Add the rfs_needed check when
 record flow hash

From: gfree.wind@....163.com
Date: Wed, 24 May 2017 15:35:59 +0800

>  
> +static inline void sock_rps_record_flow_hash(__u32 hash)
> +{
> +#ifdef CONFIG_RPS
> +	if (static_key_false(&rfs_needed))
> +		_sock_rps_record_flow_hash(hash);
> +#endif
> +}
> +

This is no longer used.

If you have some plans to use it in another context, you absolutely _MUST_
post this change inside of a patch series that adds the new user as well.

Otherwise it is impossible to determine the correctness and
appropriateness of your changes.

Thanks.