netdev - Re:Re: [PATCH net-next] net: rps: Add the rfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <232a9725.7cb5.15c422b9d3b.Coremail.gfree.wind@vip.163.com>
Date:   Fri, 26 May 2017 08:32:53 +0800 (CST)
From:   "Gao Feng" <gfree.wind@....163.com>
To:     "David Miller" <davem@...emloft.net>,
        "Eric Dumazet" <eric.dumazet@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re:Re: [PATCH net-next] net: rps: Add the rfs_needed check when
 record flow hash

Hi David & Eric,

At 2017-05-26 01:11:41, "David Miller" <davem@...emloft.net> wrote:
>From: gfree.wind@....163.com
>Date: Wed, 24 May 2017 15:35:59 +0800
>
>>  
>> +static inline void sock_rps_record_flow_hash(__u32 hash)
>> +{
>> +#ifdef CONFIG_RPS
>> +	if (static_key_false(&rfs_needed))
>> +		_sock_rps_record_flow_hash(hash);
>> +#endif
>> +}
>> +
>
>This is no longer used.
>
>If you have some plans to use it in another context, you absolutely _MUST_
>post this change inside of a patch series that adds the new user as well.
>
>Otherwise it is impossible to determine the correctness and
>appropriateness of your changes.
>
>Thanks.

The sock_rps_record_flow_hash is still used now.
There is only one caller which is tun_flow_update in file tun.c.

Best Regards
Feng