netdev - Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e56d973-450e-7dfe-5a33-23922d449cd5@redhat.com>
Date:   Fri, 26 May 2017 16:01:16 -0400
From:   Vlad Yasevich <vyasevic@...hat.com>
To:     David Ahern <dsahern@...il.com>,
        Vladislav Yasevich <vyasevich@...il.com>,
        netdev@...r.kernel.org
Cc:     roopa@...ulusnetworks.com, jiri@...nulli.us, vfalico@...il.com,
        andy@...yhouse.net
Subject: Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link
 messages

On 05/26/2017 03:40 PM, David Ahern wrote:
> On 5/25/17 9:31 AM, Vladislav Yasevich wrote:
>> @@ -911,4 +912,14 @@ enum {
>>  
>>  #define IFLA_XDP_MAX (__IFLA_XDP_MAX - 1)
>>  
>> +enum {
>> +	IFLA_EVENT_UNSPEC,
>> +	IFLA_EVENT_REBOOT,
>> +	IFLA_EVENT_FEAT_CHANGE,
>> +	IFLA_EVENT_BONDING_FAILOVER,
>> +	IFLA_EVENT_NOTIFY_PEERS,
>> +	IFLA_EVENT_RESEND_IGMP,
>> +	IFLA_EVENT_CHANGE_INFO_DATA,
>> +};
>> +
>>  #endif /* _UAPI_LINUX_IF_LINK_H */
> 
> I agree these are unique events that userspace might care about.
> 
> I'd prefer better names for the userspace api for a couple of those
> along with a description in the header file so userspace knows why the
> event was generated.
> 
> How about something like this:
> 
> enum {
> 	IFLA_EVENT_NONE,
> 	IFLA_EVENT_REBOOT,		/* internal reset / reboot */
> 	IFLA_EVENT_FEATURES,		/* change in offload features */
> 	IFLA_EVENT_BONDING_FAILOVER,	/* change in active slave */
> 	IFLA_EVENT_NOTIFY_PEERS,	/* re-sent grat. arp/ndisc */
> 	IFLA_EVENT_IGMP_RESEND,		/* re-sent IGMP JOIN */
> 	IFLA_EVENT_BONDING_OPTIONS,	/* change in bonding options */
> };
> 

Ok.  I'll change and re-submit.

> Also, generically the IFLA_EVENT attribute should be considered
> independent of NETDEV_ events.
> 
> For example, userspace should be notified if the speed / duplex for a
> device changes, so we could have another one of these -- e.g.,
> IFLA_EVENT_SPEED -- that does not correlate to NETDEV_SPEED since
> nothing internal to the network stack cares about speed changes, or
> perhaps more generically it is IFLA_EVENT_LINK_SETTING.
> 

Ok.  We could do a translation between netdev event and IFLA_EVENT attribute value
earlier (say in rtnetlink_event) and pass that along.  This would allow calls
from other places, assuming proper IFLA_EVENT attribute value and translation
is defined.

Would that address your concerns?

> The rest of the patch looks ok to me.
> 

Thanks
-vlad