netdev - Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d8f7bc5-bf2d-19f3-a27a-5a56f1273a6f@gmail.com>
Date:   Fri, 26 May 2017 14:04:00 -0600
From:   David Ahern <dsahern@...il.com>
To:     vyasevic@...hat.com, Vladislav Yasevich <vyasevich@...il.com>,
        netdev@...r.kernel.org
Cc:     roopa@...ulusnetworks.com, jiri@...nulli.us, vfalico@...il.com,
        andy@...yhouse.net
Subject: Re: [PATCH V5 1/2] rtnl: Add support for netdev event to link
 messages

On 5/26/17 2:01 PM, Vlad Yasevich wrote:
>> Also, generically the IFLA_EVENT attribute should be considered
>> independent of NETDEV_ events.
>>
>> For example, userspace should be notified if the speed / duplex for a
>> device changes, so we could have another one of these -- e.g.,
>> IFLA_EVENT_SPEED -- that does not correlate to NETDEV_SPEED since
>> nothing internal to the network stack cares about speed changes, or
>> perhaps more generically it is IFLA_EVENT_LINK_SETTING.
>>
> 
> Ok.  We could do a translation between netdev event and IFLA_EVENT attribute value
> earlier (say in rtnetlink_event) and pass that along.  This would allow calls
> from other places, assuming proper IFLA_EVENT attribute value and translation
> is defined.
> 
> Would that address your concerns?

yes. that code re-factoring can be done when it is needed.