netdev - RE: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM4PR0501MB19409139227E11A4A7F82F0FDBF30@AM4PR0501MB1940.eurprd05.prod.outlook.com>
Date:   Mon, 29 May 2017 16:09:06 +0000
From:   Ilan Tayari <ilant@...lanox.com>
To:     Ilan Tayari <ilant@...lanox.com>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>
CC:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Saeed Mahameed <saeedm@....mellanox.co.il>,
        "David S. Miller" <davem@...emloft.net>,
        "Doug Ledford" <dledford@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "jsorensen@...com" <jsorensen@...com>,
        "Andy Shevchenko" <andy.shevchenko@...il.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        Alan Tull <atull@...nsource.altera.com>,
        "yi1.li@...ux.intel.com" <yi1.li@...ux.intel.com>,
        Boris Pismenny <borisp@...lanox.com>
Subject: RE: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova



> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> 
> > -----Original Message-----
> > From: Jason Gunthorpe [mailto:jgunthorpe@...idianresearch.com]
> > Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova
> >
> > On Mon, May 29, 2017 at 03:58:33PM +0000, Ilan Tayari wrote:
> > > > From: Jason Gunthorpe [mailto:jgunthorpe@...idianresearch.com]
> > > > Subject: Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for
> > Innova
> > > >
> > > > On Sun, May 28, 2017 at 07:22:27AM +0000, Ilan Tayari wrote:
> > > >
> > > > > This is neither PCI-bar mapped, nor mailbox command.
> > > > > The FPGA is indeed a bump-on-the-wire.
> > > > > (It has I2C to the CX4 chip, but that is for debug purposes, and
> too
> > > > slow
> > > > > to perform real programming)
> > > >
> > > > Wait.. So if it truely has nothing to do with the existing mellanox
> > > > driver, then nothing more than the fpga loader should be in the mlx5
> > > > directory?
> > >
> > > True, except in specific cases when the FPGA may mangle the packets in
> > > a way that the netdevice configures, and the driver needs to adapt the
> > > data path.
> >
> > > Such is the case of IPSec and TLS offloads.
> > > Those are tied to the mlx5 Ethernet driver (isolated with a kconfig).
> >
> > But there is nothing stopping this sort of FPGA mangling logic being
> > downstream of any NIC, Mellanox is just the first to do this.
> >
> > I think you'd be better to add something to the net stack to model
> > this post-nic mangling hardware, than trying to hide it in a driver.
> 
> Of course.
> 
> For IPSec, this is already in the kernel.
> See this patchset:
> http://www.mail-archive.com/netdev@vger.kernel.org/msg162876.html

Sorry, I pointed at the RFC by mistake.

This is the relevant pull request:
https://patchwork.ozlabs.org/patch/752707/

> 
> For TLS, Dave Watson is working with our guys to add it.
> 
> >
> > Jason