netdev - Re: [PATCH net-next 1/1] netvsc: Add #include's for csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1496167401.2618.27.camel@perches.com>
Date:   Tue, 30 May 2017 11:03:21 -0700
From:   Joe Perches <joe@...ches.com>
To:     mikelley@...rosoft.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com,
        jasowang@...hat.com, leann.ogasawara@...onical.comi,
        marcelo.cerri@...onical.com, sthemmin@...rosoft.com
Subject: Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function
 declarations

On Tue, 2017-05-30 at 10:43 -0700, Michael Kelley wrote:
> Add direct #include statements for declarations of csum_tcpudp_magic()
> and csum_ipv6_magic(). While the needed #include's are picked up
> indirectly for the x86 architecture, they aren't on other
> architectures, resulting in compile errors.
[]
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 4421a6d..ca952b3 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -37,6 +37,8 @@
>  #include <net/route.h>
>  #include <net/sock.h>
>  #include <net/pkt_sched.h>
> +#include <asm/checksum.h>

Maybe
#include <net/checksum.h>
instead?

> +#include <net/ip6_checksum.h>
>  
>  #include "hyperv_net.h"
>