netdev - Re: [net] vxlan: fix use-after-free on deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170601.115439.2242460950378515228.davem@davemloft.net>
Date:   Thu, 01 Jun 2017 11:54:39 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     markb@...lanox.com
Cc:     jbenc@...hat.com, roopa@...ulusnetworks.com, netdev@...r.kernel.org
Subject: Re: [net] vxlan: fix use-after-free on deletion

From: Mark Bloch <markb@...lanox.com>
Date: Thu, 1 Jun 2017 11:43:35 +0300

> Adding a vxlan interface to a socket isn't symmetrical, while adding
> is done in vxlan_open() the deletion is done in vxlan_dellink().
> This can cause a use-after-free error when we close the vxlan
> interface before deleting it.
> 
> We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call
> it from vxlan_stop() to match the call from vxlan_open().
> 
> Signed-off-by: Mark Bloch <markb@...lanox.com>

Please add an appropriate Fixes: tag.

Thank you.