netdev - Re: [net] vxlan: fix use-after-free on deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1f40352-0d67-f14c-2b52-69c908f992de@mellanox.com>
Date:   Thu, 1 Jun 2017 14:32:49 +0300
From:   Roi Dayan <roid@...lanox.com>
To:     Jiri Benc <jbenc@...hat.com>, Mark Bloch <markb@...lanox.com>
CC:     <roid@...lanox.com>, <roopa@...ulusnetworks.com>,
        <netdev@...r.kernel.org>
Subject: Re: [net] vxlan: fix use-after-free on deletion



On 01/06/2017 11:53, Jiri Benc wrote:
> On Thu, 1 Jun 2017 11:43:35 +0300, Mark Bloch wrote:
>> Adding a vxlan interface to a socket isn't symmetrical, while adding
>> is done in vxlan_open() the deletion is done in vxlan_dellink().
>> This can cause a use-after-free error when we close the vxlan
>> interface before deleting it.
>>
>> We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call
>> it from vxlan_stop() to match the call from vxlan_open().
>>
>> Signed-off-by: Mark Bloch <markb@...lanox.com>
>
> Acked-by: Jiri Benc <jbenc@...hat.com>
>

Hi, I did some tests and didn't reproduce the original kasan issue
reported.

Tested-by: Roi Dayan <roid@...lanox.com>