netdev - Re: [net] vxlan: fix use-after-free on deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMgcDQQTetaR_DNLfZWnjHE=25in7bFcWWfx4tKpf+j4kg@mail.gmail.com>
Date:   Thu, 1 Jun 2017 13:17:21 +0300
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Mark Bloch <markb@...lanox.com>
Cc:     Jiri Benc <jbenc@...hat.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [net] vxlan: fix use-after-free on deletion

On Thu, Jun 1, 2017 at 11:43 AM, Mark Bloch <markb@...lanox.com> wrote:
> Adding a vxlan interface to a socket isn't symmetrical, while adding
> is done in vxlan_open() the deletion is done in vxlan_dellink().
> This can cause a use-after-free error when we close the vxlan
> interface before deleting it.
>
> We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call
> it from vxlan_stop() to match the call from vxlan_open().
>

If you are fixing a specific commit, best to put a proper Fixes that here

> Signed-off-by: Mark Bloch <markb@...lanox.com>