netdev - Re: [PATCH net-next] ipv4: route: restore skb_dst_set in inet_rtm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59306E5E.9050806@gmail.com>
Date:   Thu, 01 Jun 2017 12:43:26 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     David Miller <davem@...emloft.net>, roopa@...ulusnetworks.com
CC:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net-next] ipv4: route: restore skb_dst_set in inet_rtm_getroute

On 06/01/2017 08:34 AM, David Miller wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> Date: Wed, 31 May 2017 22:53:25 -0700
> 
>> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>>
>> recent updates to inet_rtm_getroute dropped skb_dst_set in
>> inet_rtm_getroute. This patch restores it because it is
>> needed to release the dst correctly.
>>
>> Fixes: 3765d35ed8b9 ("net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup")
>> Reported-by: John Fastabend <john.fastabend@...il.com>
>> Signed-off-by: David Ahern <dsahern@...il.com>
>> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> Applied.
> 

Thanks Roopa this fixes the regression on my systems.

.John