netdev - Re: [PATCH net] net: bridge: start hello timer only if device is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <alpine.LFD.2.20.1706012141230.1834@schleppi>
Date:   Thu, 1 Jun 2017 21:44:01 +0200 (CEST)
From:   Sebastian Ott <sebott@...ux.vnet.ibm.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
cc:     netdev@...r.kernel.org, davem@...emloft.net,
        roopa@...ulusnetworks.com, Xin Long <lucien.xin@...il.com>,
        Ivan Vecera <cera@...a.cz>
Subject: Re: [PATCH net] net: bridge: start hello timer only if device is
 up

On Thu, 1 Jun 2017, Nikolay Aleksandrov wrote:
> When the transition of NO_STP -> KERNEL_STP was fixed by always calling
> mod_timer in br_stp_start, it introduced a new regression which causes
> the timer to be armed even when the bridge is down, and since we stop
> the timers in its ndo_stop() function, they never get disabled if the
> device is destroyed before it's upped.
> 
> To reproduce:
> $ while :; do ip l add br0 type bridge hello_time 100; brctl stp br0 on;
> ip l del br0; done;
> 
> CC: Xin Long <lucien.xin@...il.com>
> CC: Ivan Vecera <cera@...a.cz>
> CC: Sebastian Ott <sebott@...ux.vnet.ibm.com>
> Reported-by: Sebastian Ott <sebott@...ux.vnet.ibm.com>
> Fixes: 6d18c732b95c ("bridge: start hello_timer when enabling KERNEL_STP in br_stp_start")
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> Sebastian it'd be great if you can test the patch as well.

I did and can confirm that it fixes the problem.

Thanks,
Sebastian