netdev - RE: [PATCH net-next] net: phy: smsc: Implement PHY statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D40AA9CB9@CHN-SV-EXMX02.mchp-main.com>
Date:   Fri, 2 Jun 2017 23:35:07 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <andrew@...n.ch>, <davem@...emloft.net>
CC:     <vivien.didelot@...oirfairelinux.com>, <cphealy@...il.com>,
        <nikita.yoush@...entembedded.com>, <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] net: phy: smsc: Implement PHY statistics

Andrew,

>  static int smsc_phy_probe(struct phy_device *phydev)
>  {
>  	struct device *dev = &phydev->mdio.dev;
> @@ -206,6 +258,11 @@ static struct phy_driver smsc_phy_driver[] = {
>  	.ack_interrupt	= smsc_phy_ack_interrupt,
>  	.config_intr	= smsc_phy_config_intr,
> 
> +	/* Statistics */
> +	.get_sset_count = smsc_get_sset_count,
> +	.get_strings = smsc_get_strings,
> +	.get_stats = smsc_get_stats,
> +
...
> 
> +	/* Statistics */
> +	.get_sset_count = smsc_get_sset_count,
> +	.get_strings = smsc_get_strings,
> +	.get_stats = smsc_get_stats,
> +
...
> +	/* Statistics */
> +	.get_sset_count = smsc_get_sset_count,
> +	.get_strings = smsc_get_strings,
> +	.get_stats = smsc_get_stats,
> +
...
> +	/* Statistics */
> +	.get_sset_count = smsc_get_sset_count,
> +	.get_strings = smsc_get_strings,
> +	.get_stats = smsc_get_stats,
> +
Just cosmetic thing.
How about aligning with other members in structure like
> +	.get_sset_count = smsc_get_sset_count,
> +	.get_strings     = smsc_get_strings,
> +	.get_stats        = smsc_get_stats,

Reviewed-By: Woojung Huh <Woojung.Huh@...rochip.com>