netdev - Re: [PATCH net] geneve: fix needed_headroom and max_mtu for collect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_CL75iYcRa=T3qDvaRrS__=7chdczGJierUw4BMv9aOEw@mail.gmail.com>
Date:   Sat, 3 Jun 2017 22:34:43 -0700
From:   Pravin Shelar <pshelar@....org>
To:     Eric Garver <e@...g.me>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net] geneve: fix needed_headroom and max_mtu for collect_metadata

On Fri, Jun 2, 2017 at 11:54 AM, Eric Garver <e@...g.me> wrote:
> Since commit 9b4437a5b870 ("geneve: Unify LWT and netdev handling.")
> when using COLLECT_METADATA geneve devices are created with too small of
> a needed_headroom and too large of a max_mtu. This is because
> ip_tunnel_info_af() is not valid with the device level info when using
> COLLECT_METADATA and we mistakenly fall into the IPv4 case.
>
> For COLLECT_METADATA, always use the worst case of ipv6 since both
> sockets are created.
>
> Fixes: 9b4437a5b870 ("geneve: Unify LWT and netdev handling.")
> Signed-off-by: Eric Garver <e@...g.me>

Acked-by: Pravin B Shelar <pshelar@....org>

Thanks.