netdev - Re: [PATCH net] geneve: fix needed_headroom and max_mtu for collect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170604.200427.359347649096470847.davem@davemloft.net>
Date:   Sun, 04 Jun 2017 20:04:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     e@...g.me
Cc:     pshelar@....org, netdev@...r.kernel.org
Subject: Re: [PATCH net] geneve: fix needed_headroom and max_mtu for
 collect_metadata

From: Eric Garver <e@...g.me>
Date: Fri,  2 Jun 2017 14:54:10 -0400

> Since commit 9b4437a5b870 ("geneve: Unify LWT and netdev handling.")
> when using COLLECT_METADATA geneve devices are created with too small of
> a needed_headroom and too large of a max_mtu. This is because
> ip_tunnel_info_af() is not valid with the device level info when using
> COLLECT_METADATA and we mistakenly fall into the IPv4 case.
> 
> For COLLECT_METADATA, always use the worst case of ipv6 since both
> sockets are created.
> 
> Fixes: 9b4437a5b870 ("geneve: Unify LWT and netdev handling.")
> Signed-off-by: Eric Garver <e@...g.me>

Applied and queued up for -stable, thanks.