netdev - Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 15:45:35 +0200
From:   Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:     Antoine Tenart <antoine.tenart@...e-electrons.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        gregory.clement@...e-electrons.com, mw@...ihalf.com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set
 function

Hello,

On Tue,  6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote:
> The mvpp22_port_mii_set() function was added by 2697582144dd, but the
> function directly returns without doing anything. This return was used
> when debugging and wasn't removed before sending the patch. Fix this.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com>

Please add:

Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")

with this:

Acked-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>

I am wondering if we shouldn't Cc: stable as well. I don't think we
have seen issues on our side because U-Boot does the necessary
initialization, but people using other bootloaders might have issues.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com