netdev - Re: [PATCH net] net: Zero ifla_vf_info in rtnl_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b3edfcb-a278-a847-432e-8fe898cbe6ab@gmail.com>
Date:   Wed, 7 Jun 2017 16:10:41 -0700
From:   Greg Rose <gvrose8192@...il.com>
To:     Yuval Mintz <yuval.mintz@...ium.com>
Cc:     Michal Schmidt <mschmidt@...hat.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: Zero ifla_vf_info in rtnl_fill_vfinfo()

On 06/07/2017 11:00 AM, Yuval Mintz wrote:
> Some of the structure's fields are not initialized by the
> rtnetlink. If driver doesn't set those in ndo_get_vf_config(),
> they'd leak memory to user.
>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...ium.com>
> CC: Michal Schmidt <mschmidt@...hat.com>
> ---
>   net/core/rtnetlink.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 9e2c0a7..5e61456 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1124,6 +1124,8 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,
>       struct ifla_vf_mac vf_mac;
>       struct ifla_vf_info ivi;
>
> +    memset(&ivi, 0, sizeof(ivi));
> +
>       /* Not all SR-IOV capable drivers support the
>        * spoofcheck and "RSS query enable" query.  Preset to
>        * -1 so the user space tool can detect that the driver
> @@ -1132,7 +1134,6 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,
>       ivi.spoofchk = -1;
>       ivi.rss_query_en = -1;
>       ivi.trusted = -1;
> -    memset(ivi.mac, 0, sizeof(ivi.mac));
>       /* The default value for VF link state is "auto"
>        * IFLA_VF_LINK_STATE_AUTO which equals zero
>        */
>
It's been a few years since I worked in this code but I do recall this portion.  Good idea...

Thanks!

Reviewed-by: Greg Rose <gvrose8192@...il.com>