netdev - Re: [PATCH net-next 2/8] qed: Revise ll2 Rx completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170608.192433.1559179766198812724.davem@davemloft.net>
Date:   Thu, 08 Jun 2017 19:24:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...ium.com
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        Michal.Kalderon@...ium.com
Subject: Re: [PATCH net-next 2/8] qed: Revise ll2 Rx completion

From: Yuval Mintz <Yuval.Mintz@...ium.com>
Date: Thu, 8 Jun 2017 19:13:17 +0300

> +struct qed_ll2_comp_rx_data {
> +	u8 connection_handle;
> +	void *cookie;
> +	dma_addr_t rx_buf_addr;
> +	u16 parse_flags;
> +	u16 vlan;
> +	bool b_last_packet;
> +
> +	union {
> +		u8 placement_offset;
> +		u8 data_length_error;
> +	} u;
> +	union {
> +		u16 packet_length;
> +		u16 data_length;
> +	} length;
> +
> +	u32 opaque_data_0;
> +	u32 opaque_data_1;
> +
> +	/* GSI only */
> +	u32 gid_dst[4];
> +	u16 qp_id;
> +};
> +

Again, a lot of unnecessary padding in the structure due to suboptimal
member ordering.

Please fix this.

Thank you.