netdev - Re: [PATCH] net: vrf: Make add_fib_rules per network namespace flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170608.192836.1501451775101159374.davem@davemloft.net>
Date:   Thu, 08 Jun 2017 19:28:36 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org, petrm@...lanox.com
Subject: Re: [PATCH] net: vrf: Make add_fib_rules per network namespace flag

From: David Ahern <dsahern@...il.com>
Date: Thu,  8 Jun 2017 11:31:11 -0600

> Commit 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create")
> adds the l3mdev FIB rule the first time a VRF device is created. However,
> it only creates the rule once and only in the namespace the first device
> is created - which may not be init_net. Fix by using the net_generic
> capability to make the add_fib_rules flag per network namespace.
> 
> Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create")
> Reported-by: Petr Machata <petrm@...lanox.com>
> Signed-off-by: David Ahern <dsahern@...il.com>

Yeah that's not very helpful behavior.

Applied and queued up for -stable, thanks David.